Clear where non-American English appears #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you simplify the lengthy script? |
jserv
reviewed
Feb 25, 2025
jserv
reviewed
Feb 25, 2025
jserv
reviewed
Feb 25, 2025
jserv
reviewed
Feb 25, 2025
|
Which formatter is this script using? |
jserv
reviewed
Feb 26, 2025
I have not decided yet. You can simply follow the existing indention. |
|
Should I squash my local commits into a single commit and then force push, or simply add a new commit? |
Always squash for single purpose commits. |
Previously, warnings about non-American English words in commit messages did not indicate the specific word or its exact location. This commit improves the hook by outputting the precise line number and word that triggered the warning. A new function, 'get_all_match_positions', was introduced to locate the first occurrence of each target word in a multi-line string. We now preserve blank lines in the commit message by using the variable 'FULL_COMMIT_MSG_WITH_SPACE', so that the line search functionality operates correctly. This change makes it easier for users to quickly identify and correct non-American English words in their commit messages. Change-Id: I8a2b7eb3984b06b0be6506ca4f410ca857fe50a7
Dennis40816
force-pushed
the
clear-where-the-non-american-english-appears
branch
from
8a2428c to
d39d920
Compare
|
Thank @Dennis40816 for contributing! |
Dennis40816
added a commit
to Dennis40816/lab0-c
that referenced
this pull request
Mar 3, 2025
PR sysprog21#209's functionality was broken due to changes introduced in PR sysprog21#214, specifically in commit '4a8d8b5', where some occurrences of 'COMMIT_MSG_LINES' were replaced with 'commit_msg_lines' without updating all relevant functions. This commit fixes the issue by replacing all instances of 'COMMIT_MSG_LINES' with 'commit_msg_lines', ensuring consistency and restoring the functionality introduced in PR sysprog21#209. Change-Id: I0c93617be83c5f24b1e17678566883c0481ddc48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the hook that detects non-American English in commit messages.
Previously, the hook would only indicate the presence of non-American English words without specifying their locations or the words themselves. Now, the hook clearly reports the exact line numbers and problematic words, making it easier for users to identify and correct the issues.
A test is conducted below.
Before
After